Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atlasaction: add context parameter to migrate/apply #104

Merged
merged 6 commits into from
Nov 1, 2023

Conversation

dorav
Copy link
Contributor

@dorav dorav commented Nov 1, 2023

No description provided.

Copy link

github-actions bot commented Nov 1, 2023

Atlas Lint Report

Analyzed migrations2

StatusStepResultDiagnostics
Detect New Migration FilesFound 0 new migration files (from 0 total)
Replay Migration FilesLoaded 0 changes on dev database
Connect your project to Atlas Cloud to get more safety checks

Migrations automatically reviewed by Atlas

Copy link

github-actions bot commented Nov 1, 2023

Atlas Lint Report

Analyzed migrations

StatusStepResultDiagnostics
Detect New Migration FilesFound 0 new migration files (from 0 total)
Replay Migration FilesLoaded 0 changes on dev database
Connect your project to Atlas Cloud to get more safety checks

Migrations automatically reviewed by Atlas

Copy link

github-actions bot commented Nov 1, 2023

atlas migrate lint results:

Step Link
1 new migration file detected  
ERD and Visual Diff generated View Visualization
No issues found. Full Report

Migrations automatically reviewed with Atlas

Copy link

github-actions bot commented Nov 1, 2023

atlas migrate lint results:

Step Link
1 new migration file detected  
ERD and Visual Diff generated View Visualization
1 error found Full Report

Migrations automatically reviewed with Atlas

@dorav dorav force-pushed the add_context_to_migrate_apply branch from 989411c to 6f6daf9 Compare November 1, 2023 12:58
@dorav dorav force-pushed the add_context_to_migrate_apply branch from 6f6daf9 to 7c469b7 Compare November 1, 2023 13:01
Copy link
Member

@rotemtam rotemtam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need the context here ? Version is a global var anyways

@dorav dorav force-pushed the add_context_to_migrate_apply branch from bfad464 to 6db27a4 Compare November 1, 2023 14:21
@dorav dorav force-pushed the add_context_to_migrate_apply branch from bf018e6 to 93361f4 Compare November 1, 2023 14:36
// RunAction is a command to run one of the Atlas GitHub Actions.
type RunAction struct {
Action string `help:"Command to run" required:""`
Action string `help:"Command to run" required:""`
Version VersionFlag `help:"Prints the version and exits"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this print the version on atlas-action version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on --version

Base automatically changed from upgrade_sdk to master November 1, 2023 15:37
Copy link
Member

@a8m a8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer we stay consistent with the version command, or remove it completely.

@dorav dorav merged commit 00906da into master Nov 1, 2023
7 checks passed
@dorav dorav deleted the add_context_to_migrate_apply branch November 1, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants