-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
atlasaction: add context parameter to migrate/apply #104
Conversation
Atlas Lint ReportAnalyzed migrations2
Migrations automatically reviewed by Atlas |
Atlas Lint ReportAnalyzed migrations
Migrations automatically reviewed by Atlas |
Migrations automatically reviewed with Atlas |
Migrations automatically reviewed with Atlas |
989411c
to
6f6daf9
Compare
6f6daf9
to
7c469b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need the context here ? Version is a global var anyways
bfad464
to
6db27a4
Compare
bf018e6
to
93361f4
Compare
// RunAction is a command to run one of the Atlas GitHub Actions. | ||
type RunAction struct { | ||
Action string `help:"Command to run" required:""` | ||
Action string `help:"Command to run" required:""` | ||
Version VersionFlag `help:"Prints the version and exits"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this print the version on atlas-action version
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on --version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer we stay consistent with the version command, or remove it completely.
No description provided.