Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds inner-shadow-highlight variable to inner shadow 1-4 #399

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

argyleink
Copy link
Owner

Screenshot 2023-08-29 at 3 54 26 PM

@stackblitz
Copy link

stackblitz bot commented Aug 29, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@argyleink argyleink mentioned this pull request Aug 29, 2023
@github-actions
Copy link

github-actions bot commented Aug 29, 2023

Visit the preview URL for this PR (updated for commit 3212a75):

https://open-props--pr399-inner-shadow-highlig-9zmajy1z.web.app

(expires Thu, 07 Sep 2023 04:43:01 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 32524ac481f54edda55dc959fa4614cf1acc8c11

@argyleink
Copy link
Owner Author

tests are failing because I added a new prop

@argyleink argyleink marked this pull request as ready for review September 20, 2023 14:29
@argyleink argyleink merged commit 4663e86 into main Sep 20, 2023
4 checks passed
@argyleink argyleink deleted the inner-shadow-highlights branch September 20, 2023 14:29
@ezzatron
Copy link

@argyleink Just a heads up that the inner shadow highlight looks a bit... weird on light themes.

With --inner-shadow-highlight it looks kind of like there's a dark 1px border along the top edge of the inset:

Screenshot 2023-10-24 at 20 56 32

Without --inner-shadow-highlight:

Screenshot 2023-10-24 at 20 56 21

(Note that this component deliberately only uses the inset shadow on the top and bottom)

As usual, it's easy to override, but I thought I'd bring it up in case it was just an oversight. Cheers!

@argyleink
Copy link
Owner Author

ewww that's gross agree, lemme fix!

@argyleink
Copy link
Owner Author

fixed in v1.6.9 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants