fix: Don't use perf in plonk-artifacts workflow
#197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the setup action will set both `SP1_DEV=true` and `FRI_QUERIES=1`, the plonk artifact generation fails. We can override `SP1_DEV` but cannot override `FRI_QUERIES` since different StarkMachines use different values. Unsetting variables set via `GITHUB_ENV` is not currently supported according to actions/runner#1126 So just pass `perf: false` instead
samuelburnham
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the setup action will set both
SP1_DEV=trueandFRI_QUERIES=1, the plonk artifact generation fails. We can overrideSP1_DEVbut cannot overrideFRI_QUERIESsince different StarkMachines use different values (and they are all overridden by the sameFRI_QUERIESenvvar). Unsetting variables set viaGITHUB_ENVis not currently supported according to actions/runner#1126So just pass
perf: falseinstead. TheMakefileuses--releaseand sets-Ctarget-cpu=nativeby itself so we don't need any of theperfsetup items