refactor: Remove BLS12381 G2 Add and Double functionalities #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huitseeker
force-pushed
the
remove_bls12381_g2
branch
from
1ef03e9 to
efa1643
Compare
huitseeker
force-pushed
the
remove_bls12381_g2
branch
2 times, most recently
from
540fb6b to
7a32844
Compare
wwared
reviewed
Oct 4, 2024
wwared
previously approved these changes
Oct 4, 2024
- Removed the `bls12381-g2-add` and `bls12381-g2-double` functions related to BLS12381 G2Affine points from various files. - Deleted associated tests, files, modules, and references from test suite, codebase, libraries, and syscall map.
huitseeker
force-pushed
the
remove_bls12381_g2
branch
from
131cad0 to
e796227
Compare
wwared
approved these changes
Oct 5, 2024
storojs72
approved these changes
Oct 5, 2024
adr1anh
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bls12381-g2-addandbls12381-g2-doublefunctions related to BLS12381 G2Affine points from various files.Thanks @storojs72 for the work, those were not as useful as hoped in the end 😢
Note
this will require argumentcomputer/bls12_381#23