Skip to content

Commit

Permalink
fix: Don't use perf in plonk-artifacts workflow
Browse files Browse the repository at this point in the history
Since the setup action will set both `SP1_DEV=true` and `FRI_QUERIES=1`, the plonk artifact generation fails. We can override `SP1_DEV` but cannot override `FRI_QUERIES` since different StarkMachines use different values. Unsetting variables set via `GITHUB_ENV` is not currently supported according to actions/runner#1126

So just pass `perf: false` instead
  • Loading branch information
wwared authored Oct 28, 2024
1 parent 8c1c1ef commit b6fc2dd
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/plonk-artifacts.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ jobs:
uses: ./.github/actions/setup
with:
pull_token: ${{ secrets.REPO_TOKEN }}
perf: false
- name: Install AWS CLI
run: |
sudo apt-get update
Expand Down Expand Up @@ -80,8 +81,6 @@ jobs:
echo "VERSION=$VERSION" | tee -a $GITHUB_ENV
echo "needs-update=$NEEDS_UPDATE" | tee -a $GITHUB_OUTPUT
# Disable `SP1_DEV` as it breaks artifact generation
echo "SP1_DEV=false" | tee -a $GITHUB_ENV
- name: Generate Plonk artifacts
if: ${{ steps.check-s3.outputs.needs-update == 'true' }}
run: |
Expand Down

0 comments on commit b6fc2dd

Please sign in to comment.