Make memoset API generic #1044

gabriel-barrett · 2024-01-12T00:31:41Z

This PR makes the memoset API generic, removing all the hardcoded DemoQuery from their methods

huitseeker

I'm ok with this, but I note the rapid proliferation of generic parameters is an impediment to readability / accessibility / maintenability.

gabriel-barrett added 2 commits January 11, 2024 21:02

moved demo to own file

50863bf

make mod generic

fb38df0

gabriel-barrett requested a review from a team as a code owner January 12, 2024 00:31

scope synthesize

47db887

gabriel-barrett force-pushed the memoset-api branch from 67da6ff to 47db887 Compare January 12, 2024 00:40

porcuquine and others added 4 commits January 11, 2024 16:55

Be more anonymous.

5835741

removed circuit scope synthesize

7f25be3

reverted associated types

0f5441f

removed unreachable_pub

1d40c7b

porcuquine previously approved these changes Jan 12, 2024

View reviewed changes

Reimplement symbol().

c17bcc9

porcuquine dismissed their stale review via c17bcc9 January 12, 2024 04:55

removed commented lines

1a6d10b

gabriel-barrett requested a review from porcuquine January 12, 2024 11:19

circuit_scope type can be inferred

5e00541

huitseeker approved these changes Jan 12, 2024

View reviewed changes

gabriel-barrett added this pull request to the merge queue Jan 12, 2024

github-actions bot pushed a commit that referenced this pull request Jan 12, 2024

[automated] GPU Benchmark from PR #1044

d3b806c

Merged via the queue into main with commit a9a5f10 Jan 12, 2024
12 checks passed

gabriel-barrett deleted the memoset-api branch January 12, 2024 16:34

Provide feedback