chore: Remove 'fcomm' package and associated files (#871)

- Removed the entire `fcomm` module, 👋 - Deleted numerous `fcomm` related source and snapshot files from the project. - Removed `test_make_fcomm_examples` from excludedLinux Tests phase in GitHub Actions workflow - Updated README link to fcomm -> demo under 'Proofs' section. - Removed `fcomm` as workspace member in `Cargo.toml` and from GitHub Actions CI/CD setup.
argumentcomputer · Nov 8, 2023 · d9c81c1 · d9c81c1 · github-actions · Nov 8, 2023
1 parent 5de43d7
commit d9c81c1
Show file tree

Hide file tree

Showing 29 changed files with 3 additions and 2,635 deletions.
diff --git a/.github/workflows/merge-tests.yml b/.github/workflows/merge-tests.yml
@@ -26,7 +26,7 @@ jobs:
       - uses: Swatinem/rust-cache@v2
       - name: Linux Tests
         run: |
-          cargo nextest run --profile ci --workspace --cargo-profile dev-ci --run-ignored ignored-only -E 'all() - test(test_make_fcomm_examples) - test(test_demo)'
+          cargo nextest run --profile ci --workspace --cargo-profile dev-ci --run-ignored ignored-only -E 'all() - test(test_demo)'
 
   linux-arm:
     if: github.event_name != 'pull_request' || github.event.action == 'enqueued'

diff --git a/Cargo.toml b/Cargo.toml
@@ -112,7 +112,7 @@ vergen = { version = "8", features = ["build", "git", "gitcl"] }
 
 [workspace]
 resolver = "2"
-members = ["fcomm", "lurk-macros", "lurk-metrics"]
+members = ["lurk-macros", "lurk-metrics"]
 
 # Dependencies that should be kept in sync through the whole workspace
 [workspace.dependencies]

diff --git a/README.md b/README.md
@@ -26,7 +26,7 @@ Lurk's distinguishing feature relative to most zk-SNARK authoring languages is t
 
 # Proofs
 
-Integration with backend proving systems and tooling for proof generation are both still very early. Performance and user experience still have room for significant optimization and improvement, but simple examples can be found in the [fcomm example directory](fcomm/README.md).
+Integration with backend proving systems and tooling for proof generation are both still very early. Performance and user experience still have room for significant optimization and improvement, but simple examples can be found in the [demo example directory](demo/).
 
 # Backends
 - Nova is Lurk's officially-supported IVC backend. It uses Lurk Lab's Arecibo fork of the [Nova proving system](https://github.com/lurk-lab/arecibo) and the Pasta Curves.

diff --git a/fcomm/.clippy.toml b/fcomm/.clippy.toml
diff --git a/fcomm/.gitignore b/fcomm/.gitignore
diff --git a/fcomm/Cargo.toml b/fcomm/Cargo.toml
diff --git a/fcomm/README.md b/fcomm/README.md
diff --git a/fcomm/examples/.gitignore b/fcomm/examples/.gitignore
diff --git a/fcomm/examples/Makefile b/fcomm/examples/Makefile
diff --git a/fcomm/examples/chained-function.json b/fcomm/examples/chained-function.json
diff --git a/fcomm/examples/chained-input.lurk b/fcomm/examples/chained-input.lurk
diff --git a/fcomm/examples/chained-request.json b/fcomm/examples/chained-request.json
diff --git a/fcomm/examples/eval-input.lurk b/fcomm/examples/eval-input.lurk
diff --git a/fcomm/examples/fcomm b/fcomm/examples/fcomm
diff --git a/fcomm/examples/fibonacci.json b/fcomm/examples/fibonacci.json
diff --git a/fcomm/examples/fibonacci.lurk b/fcomm/examples/fibonacci.lurk
diff --git a/fcomm/examples/num-list-function.json b/fcomm/examples/num-list-function.json
diff --git a/fcomm/examples/num-list-input.lurk b/fcomm/examples/num-list-input.lurk
	`fib-ref=5de43d79b43237c0b465ea53a72b1ff6e7ab6126`	`fib-ref=d9c81c1c2d0c3220884d2c983259721bfd17ecd3`
`num-100`	`4.01 s` (✅ 1.00x)	`4.00 s` (✅ 1.00x faster)
`num-200`	`9.00 s` (✅ 1.00x)	`8.76 s` (✅ 1.03x faster)
	`fib-ref=5de43d79b43237c0b465ea53a72b1ff6e7ab6126`	`fib-ref=d9c81c1c2d0c3220884d2c983259721bfd17ecd3`
`num-100`	`3.05 s` (✅ 1.00x)	`3.05 s` (✅ 1.00x faster)
`num-200`	`7.09 s` (✅ 1.00x)	`7.04 s` (✅ 1.01x faster)