Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Introducing PCS codebase as a separate module #361

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

storojs72
Copy link
Member

Partially fixes #304.

Reorganises PCS codebase into a separate module.

Moves vanilla KZG10 utilities from ZM.

Still work in progress

Copy link
Contributor

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the commitment-related1 parts of :

  • kzg_commitment.rs
  • pedersen.rs
    should stay out of the PCS module, because the traits they are dedicated to implementing are unrelated to the EvaluationEngine. They could be in their own commitment module if you like.

Footnotes

  1. I do not consider the implementation of CommitmentKeyExtTrait for the pedersen commitment to be commitment-related, and in fact it's only used by the IPA. So that trait implementation could move to the PCS module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PCS codebase refactoring
2 participants