Commits on Jan 3, 2024

1. Expose the last outputs and number of steps from RecursiveSNARK (argu… …

   …mentcomputer#285)
   
   Both of these data are easily accessible, and could be very useful
   to clients:
   * Exposing the last outputs allows us to get the current state of
     the computation on the prover side without wasting energy
     recomputing it
   * Exposing the number of steps makes it easier to eventually pass
     `num_steps` into `CompressedSNARK::verify`

   

   jbearer authored and huitseeker committed Jan 3, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 9009b7b
   • Browse repository at this point

   Copy the full SHA

   9009b7b View commit details

   Browse the repository at this point in the history

2. Improve error handling (argumentcomputer#286) …

   * When a function already returns a `Result`, propagate errors
     instead of panicking with `expect`
   * For `NovaError::SynthesisError`, retain information about the
     original bellpepper error. Since `NovaError` implements `Clone`
     but bellpepper's `SynthesisError` does not, we keep the error
     information as a `String`.
   
   This commit only fixes low-hanging fruit in lib.rs, for functions
   that already return a `Result` and can easily propagate errors just
   by replacing `expect(...)` with `?`. There are still many `unwrap()`
   calls in functions returning `Result` in other modules, particularly
   gadgets. But I don't understand the code well in those parts, and I
   suspect some of those `unwrap()`s actually can't fail based on
   invariants of the code, so it makes perfect sense to leave them as is.
   
   Co-authored-by: Francois Garillot <[email protected]>

   

   jbearer and huitseeker committed Jan 3, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 2988796
   • Browse repository at this point

   Copy the full SHA

   2988796 View commit details

   Browse the repository at this point in the history