Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reinstate diff between 10.1.2 and 10.1.3 minus @jest/globals support + misc #606

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

mulekick
Copy link
Contributor

Summary

This pull request contains :

  1. The diff between 10.1.2 and 10.1.3 minus the non-working additional declaration for @jest/globals imports support (see 602)
  2. An edit of the rewritten main README to fix the example tests, remove any reference to the use of @jest/globals for imports and explicitly mention that it is not supported.
  3. An edit of the jest-environment-puppeteer README to align with the current recommended setup for Typescript and point to the new puppeteer docs.
  4. An additional basic test for the expect-puppeteer matchers with @jest/globals imports, disabled for now.

Test plan

  1. Test suite passes 100%.

Test suite passes 100%

@gregberge gregberge merged commit 911b243 into argos-ci:main Oct 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants