Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(settings): update settings tabs labels #1002

Merged
merged 1 commit into from
Sep 3, 2023

Conversation

jsfez
Copy link
Contributor

@jsfez jsfez commented Sep 2, 2023

No description provided.

@jsfez jsfez requested review from a team and gregberge and removed request for a team September 2, 2023 10:06
@argos-ci
Copy link

argos-ci bot commented Sep 2, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Sep 2, 2023, 10:09 AM

Copy link
Member

@gregberge gregberge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get the point. Why not Personal Projects?

The space is defined by the Breadcrumb header.

@jsfez
Copy link
Contributor Author

jsfez commented Sep 2, 2023

Argos has three "Settings" tabs in the same position, leading to different pages: Team, Personal, and Project Settings. Even as a co-creator, I find this confusing. To improve UX, I suggest renaming these tabs for clarity.

@jsfez
Copy link
Contributor Author

jsfez commented Sep 3, 2023

Do you validate the PR or do you think we should address this point by an other way?

@gregberge gregberge merged commit fe89373 into main Sep 3, 2023
6 checks passed
@gregberge gregberge deleted the update-settings-tab-labels branch September 3, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants