fix(argo-cd): Update CONTRIBUTING docs #1782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [x] versioning details - [x] remove broken links - [x] fix markdown linting errors - [x] README.md updating clarification Signed-off-by: jmeridth <[email protected]> Co-authored-by: Josh Soref <[email protected]>
Signed-off-by: jmeridth <[email protected]> Co-authored-by: Josh Soref <[email protected]>
Signed-off-by: jmeridth <[email protected]> Co-authored-by: Josh Soref <[email protected]>
Signed-off-by: jmeridth <[email protected]> Co-authored-by: Josh Soref <[email protected]>
Signed-off-by: jmeridth <[email protected]> Co-authored-by: Josh Soref <[email protected]>
Signed-off-by: jmeridth <[email protected]> Co-authored-by: Josh Soref <[email protected]>
Signed-off-by: jmeridth <[email protected]> Co-authored-by: Josh Soref <[email protected]>
Signed-off-by: jmeridth <[email protected]> Co-authored-by: Josh Soref <[email protected]>
Signed-off-by: jmeridth <[email protected]> Co-authored-by: Josh Soref <[email protected]>
jmeridth
requested review from
yann-soubeyrand,
mbevc1,
mkilchhofer,
yu-croco and
pdrastil
as code owners
mbevc1
reviewed
Jan 20, 2023
Signed-off-by: jmeridth <[email protected]>
Comments coming through on latest version, according to https://github.com/norwoodj/helm-docs#readme there is a new format we have to adhere to in order for comments to not come across Signed-off-by: jmeridth <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1781
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Changes are automatically published when merged to
main. They are not published on branches.Signed-off-by: jmeridth [email protected]
Co-authored-by: Josh Soref [email protected]