Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update getting_started.md to emphasize the usage of http/2 #21313

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
+3 −1
Open

docs: Update getting_started.md to emphasize the usage of http/2 #21313

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
84c46eb
Update getting_started.md to emphasize the usage of http/2
revitalbarletz Dec 25, 2024
70c7d57
Update getting_started.md
revitalbarletz Dec 25, 2024
50b3d6b
Merge branch 'master' into patch-5
revitalbarletz Dec 26, 2024
e8d39d1
Merge branch 'master' into patch-5
revitalbarletz Jan 5, 2025
2bf2a67
Merge branch 'master' into patch-5
revitalbarletz Jan 7, 2025
a6c5794
Merge branch 'master' into patch-5
revitalbarletz Jan 8, 2025
8e891d8
Merge branch 'master' into patch-5
revitalbarletz Jan 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion docs/getting_started.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,9 @@ Also available in Mac, Linux and WSL Homebrew:
```bash
brew install argocd
```

!!! note
To ensure proper functionality, the Argo CD CLI requires HTTP/2 support. Verify that your CLI is set up to use HTTP/2, especially if connecting to an Argo CD server over HTTPS. Check your system’s configuration or proxy settings if issues arise.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To ensure proper functionality, the Argo CD CLI requires HTTP/2 support. Verify that your CLI is set up to use HTTP/2, especially if connecting to an Argo CD server over HTTPS. Check your system’s configuration or proxy settings if issues arise.
To ensure proper functionality, the Argo CD CLI requires HTTP/2 support. Verify that your CLI is set up to use HTTP/2, especially if connecting to an Argo CD server over HTTPS. Check your system’s configuration or proxy settings if issues arise.
  1. Why do we need to emphasize on usage of http/2 here?
  2. Can you add steps that would be required for verification if CLI I set up to use the HTTP/2?
  3. Which issue can occur if you just normally install the Argo CD CLI and use it against the Argo CD server over HTTPS?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue is related to #20715.
When the user tried to follow the getting started guide, argocli login kept timing out up until enabling HTTP2.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that your CLI is set up to use HTTP/2

This is a little confusing to me. You point out that the cli uses http/2 by default. I think we should say that the gateway / ingress controller should be configured to use http/2?


## 3. Access The Argo CD API Server

By default, the Argo CD API server is not exposed with an external IP. To access the API server,
Expand Down
Loading