Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for httpcaching of github requests #21309

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

aburan28
Copy link

@aburan28 aburan28 commented Dec 24, 2024

This PR adds a LRU cache to the applicationset controller. This uses the httpcache library which is a http RoundTripper that caches requests based on etag or last modified.

Additionally this PR makes some minor changes to the github client instantiation in that it removes the dependency on oauth2 for token based auth.

Fixes issue

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Copy link

bunnyshell bot commented Dec 24, 2024

✅ Preview Environment deployed on Bunnyshell

Component Endpoints
argocd https://argocd-jbmmxo.bunnyenv.com/
argocd-ttyd https://argocd-web-cli-jbmmxo.bunnyenv.com/

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔴 /bns:stop to stop the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

aburan28 and others added 5 commits December 24, 2024 14:38
Signed-off-by: Adam Buran <[email protected]>
Signed-off-by: aburan28 <[email protected]>
Signed-off-by: aburan28 <[email protected]>
Signed-off-by: aburan28 <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: aburan28 <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: aburan28 <[email protected]>
@aburan28 aburan28 changed the title feature: add support for httpcaching of github requests feat: add support for httpcaching of github requests Dec 24, 2024
@aburan28 aburan28 force-pushed the adam--httpcache-scm branch from ccfefd8 to a2ce309 Compare December 24, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cache github api requests in ApplicationSet
2 participants