Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update go-github to use token #21292

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aburan28
Copy link

@aburan28 aburan28 commented Dec 22, 2024

Minor change here to load the token for the github client using the WIthAuthToken method instead of using the x oauth2 library. This simplifies this section of code and removes the oauth2 dependency.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Copy link

bunnyshell bot commented Dec 22, 2024

❗ Preview Environment deployment failed on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

Copy link

codecov bot commented Dec 22, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 55.19%. Comparing base (f15e1bc) to head (52f422a).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
applicationset/services/pull_request/github.go 50.00% 1 Missing ⚠️
applicationset/services/scm_provider/github.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21292      +/-   ##
==========================================
- Coverage   55.23%   55.19%   -0.05%     
==========================================
  Files         337      337              
  Lines       57055    57043      -12     
==========================================
- Hits        31515    31483      -32     
- Misses      22847    22867      +20     
  Partials     2693     2693              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aburan28 aburan28 changed the title minor change to use WithAuthToken chore: update go-github to use token Dec 22, 2024
@aburan28 aburan28 marked this pull request as ready for review December 22, 2024 18:17
@aburan28 aburan28 requested a review from a team as a code owner December 22, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant