Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use testify instead of testing.Fatal #21258

Merged
merged 1 commit into from
Jan 2, 2025
Merged

chore: use testify instead of testing.Fatal #21258

merged 1 commit into from
Jan 2, 2025

Conversation

mmorel-35
Copy link
Contributor

Description

  • uses testify instead of testing.Fatal

@mmorel-35 mmorel-35 requested a review from a team as a code owner December 19, 2024 09:36
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Dec 19, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@pasha-codefresh
Copy link
Member

Thank you! This is very important work

@pasha-codefresh
Copy link
Member

@mmorel-35 could you please check, tests fails due to your changes

@mmorel-35 mmorel-35 marked this pull request as draft December 19, 2024 09:51
@pasha-codefresh pasha-codefresh self-requested a review December 19, 2024 09:51
@pasha-codefresh pasha-codefresh dismissed their stale review December 19, 2024 09:52

doing changes

@codecov Codecov
Copy link

codecov bot commented Dec 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.22%. Comparing base (8126508) to head (a115f7f).
Report is 7 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #21258      +/-   ##
==========================================
+ Coverage   55.19%   55.22%   +0.02%     
==========================================
  Files         337      337              
  Lines       57058    57058              
==========================================
+ Hits        31496    31509      +13     
+ Misses      22863    22848      -15     
- Partials     2699     2701       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmorel-35 mmorel-35 force-pushed the testifier branch 2 times, most recently from c65ba9d to e1ba6d4 Compare December 19, 2024 12:38
@mmorel-35 mmorel-35 marked this pull request as ready for review December 19, 2024 12:39
@mmorel-35 mmorel-35 marked this pull request as draft December 19, 2024 16:12
@mmorel-35 mmorel-35 marked this pull request as ready for review December 19, 2024 16:21
@mmorel-35 mmorel-35 force-pushed the testifier branch 5 times, most recently from ed37afd to d58ac02 Compare December 26, 2024 21:20
@mmorel-35 mmorel-35 force-pushed the testifier branch 4 times, most recently from 89c2bc2 to 4c795c5 Compare December 30, 2024 13:36
@crenshaw-dev crenshaw-dev merged commit 13235ad into argoproj:master Jan 2, 2025
32 checks passed
@mmorel-35 mmorel-35 deleted the testifier branch January 3, 2025 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrii-korotkov-verkada andrii-korotkov-verkada andrii-korotkov-verkada approved these changes

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

@pasha-codefresh pasha-codefresh Awaiting requested review from pasha-codefresh

Assignees
No one assigned
Labels
ready-for-review
Projects
Argo CD Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmorel-35 @pasha-codefresh @crenshaw-dev @andrii-korotkov-verkada