Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for filtering apps by path and files #21126

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

slashexx
Copy link

@slashexx slashexx commented Dec 11, 2024

Fixes #21052

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@slashexx slashexx requested a review from a team as a code owner December 11, 2024 08:23
Copy link

bunnyshell bot commented Dec 11, 2024

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@slashexx slashexx marked this pull request as draft December 11, 2024 08:23
Signed-off-by: slashexx <[email protected]>
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 32 lines in your changes missing coverage. Please review.

Project coverage is 53.81%. Comparing base (6a3cdb6) to head (d8131cb).

Files with missing lines Patch % Lines
util/argo/argo.go 0.00% 22 Missing ⚠️
cmd/argocd/commands/app.go 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21126      +/-   ##
==========================================
- Coverage   55.19%   53.81%   -1.38%     
==========================================
  Files         324      324              
  Lines       55603    55635      +32     
==========================================
- Hits        30691    29941     -750     
- Misses      22293    23095     +802     
+ Partials     2619     2599      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI app list should be able to filter based on a list of files
1 participant