-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add generic JWT auth #20928
base: master
Are you sure you want to change the base?
feat: Add generic JWT auth #20928
Conversation
Signed-off-by: Wes Medford <[email protected]>
Signed-off-by: Wes Medford <[email protected]>
Signed-off-by: Wes Medford <[email protected]>
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Signed-off-by: Wes Medford <[email protected]>
Signed-off-by: Wes Medford <[email protected]>
Signed-off-by: Wes Medford <[email protected]>
Signed-off-by: Wes Medford <[email protected]>
Signed-off-by: Wes Medford <[email protected]>
Signed-off-by: Wes Medford <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20928 +/- ##
========================================
Coverage 55.23% 55.24%
========================================
Files 337 337
Lines 57055 57167 +112
========================================
+ Hits 31515 31581 +66
- Misses 22847 22882 +35
- Partials 2693 2704 +11 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Wes Medford <[email protected]>
That's cool, but shouldn't we at least verify a configurable |
Good call, and completely agree. Will add that as a config option. |
…e audiences Signed-off-by: Wes Medford <[email protected]>
Signed-off-by: Wes Medford <[email protected]>
Added! |
Signed-off-by: Wes Medford <[email protected]>
Closes #14250
This allows for generic JWTs to be used for authentication that are minted outside of Argo. Argo currently mints its own JWTs for auth outside of Dex, and this extends its capabilities to utilize JWTs that originate from Identity Aware Proxies.
Checklist: