Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): fix login redirect failed when basehref is set (issue #20790) #20907

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lsq645599166
Copy link
Contributor

Fixes #20790

This PR fixes an issue when the basehref is set, login will redirect failed.

Result

Before

20241122-162447.mp4

After

20241122-162040.mp4

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@lsq645599166 lsq645599166 requested a review from a team as a code owner November 22, 2024 08:25
Copy link

bunnyshell bot commented Nov 22, 2024

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@lsq645599166 lsq645599166 changed the title fix(ui): fix login redirect failed when basehref is set fix(ui): fix login redirect failed when basehref is set (issue #20790) Nov 26, 2024
@tooptoop4
Copy link

where @ishitasequeira

@lsq645599166 lsq645599166 force-pushed the fix/login_with_basehref branch 2 times, most recently from 7803a79 to 086bc71 Compare December 19, 2024 02:41
@lsq645599166 lsq645599166 force-pushed the fix/login_with_basehref branch from 086bc71 to dd52852 Compare December 26, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Base path KO during login phase
2 participants