Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change applicationset generate HTTP method to avoid route conflicts #20758

Merged

Conversation

amit-o
Copy link
Contributor

@amit-o amit-o commented Nov 11, 2024

Closes #20757
Fixes HTTP route conflict introduced in 3a5b653
I'm not sure if PUT is the correct semantic we want here, however because /api/v1/applicationsets/{name} is already taken I wasn't sure to which route to change this to. Open to change to whatever.

If possible, would appreciate this as a hotfix to 2.13
Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@amit-o amit-o requested a review from a team as a code owner November 11, 2024 16:57
Copy link

bunnyshell bot commented Nov 11, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.29%. Comparing base (b39f3b1) to head (fb21687).
Report is 180 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20758      +/-   ##
==========================================
- Coverage   55.12%   53.29%   -1.83%     
==========================================
  Files         324      337      +13     
  Lines       55256    57055    +1799     
==========================================
- Hits        30458    30406      -52     
- Misses      22184    24012    +1828     
- Partials     2614     2637      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amit-o
Copy link
Contributor Author

amit-o commented Nov 20, 2024

Thanks @andrii-korotkov-verkada, is there someone we can ping for further approval?
This is a blocker for us, so I'd appreciate it if it can be hotfixed to 2.13

@andrii-korotkov-verkada
Copy link
Contributor

I'll bring up the PRs marked with ready-for-review on the contributors meeting, hope they can take a look soon.

@amit-o
Copy link
Contributor Author

amit-o commented Dec 15, 2024

Hey @andrii-korotkov-verkada, sorry for bothering, but as it's been a few contributors meetings since I'd like to ping this again

@andrii-korotkov-verkada
Copy link
Contributor

I've put it as a my top item for the next meeting.

Co-authored-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: Amit Oren <[email protected]>
@amit-o amit-o requested a review from agaudreault December 22, 2024 10:43
Signed-off-by: Amit Oren <[email protected]>
Copy link
Member

@agaudreault agaudreault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agaudreault agaudreault merged commit 644315a into argoproj:master Dec 23, 2024
27 checks passed
@agaudreault
Copy link
Member

agaudreault commented Dec 23, 2024

/cherry-pick release-2.14

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Dec 23, 2024
…cts (#20758)

* Change applicationset generate HTTP method to avoid route conflicts

Signed-off-by: Amit Oren <[email protected]>

* Update server/applicationset/applicationset.proto

Co-authored-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: Amit Oren <[email protected]>

* Codegen

Signed-off-by: Amit Oren <[email protected]>

---------

Signed-off-by: Amit Oren <[email protected]>
Signed-off-by: Amit Oren <[email protected]>
Co-authored-by: Alexandre Gaudreault <[email protected]>
@agaudreault
Copy link
Member

/cherry-pick release-2.13

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Dec 23, 2024
…cts (#20758)

* Change applicationset generate HTTP method to avoid route conflicts

Signed-off-by: Amit Oren <[email protected]>

* Update server/applicationset/applicationset.proto

Co-authored-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: Amit Oren <[email protected]>

* Codegen

Signed-off-by: Amit Oren <[email protected]>

---------

Signed-off-by: Amit Oren <[email protected]>
Signed-off-by: Amit Oren <[email protected]>
Co-authored-by: Alexandre Gaudreault <[email protected]>
crenshaw-dev pushed a commit that referenced this pull request Dec 23, 2024
…cts (#20758) (#21299)

* Change applicationset generate HTTP method to avoid route conflicts



* Update server/applicationset/applicationset.proto




* Codegen



---------

Signed-off-by: Amit Oren <[email protected]>
Signed-off-by: Amit Oren <[email protected]>
Co-authored-by: Amit Oren <[email protected]>
Co-authored-by: Alexandre Gaudreault <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

New applicationset generate endpoint conflicts with existing one
4 participants