Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ember4.12 #43

Closed
wants to merge 4 commits into from
Closed

Conversation

veelci
Copy link
Contributor

@veelci veelci commented May 10, 2024

Update from Ember 3.28 to Ember 4.12

Things to note:

  • I did the upgrade in 3 stages, 3.28 to 4.4, 4.4 to 4.8, and 4.8 to 4.12
  • I added the test styles to .stylelintignore since the minified boostrap styles were triggering linting errors
  • The project appears to use yarn, but useYarn: true is not present in the ember-try config
  • formatters.formatZipcode(94606) returns a number instead of a string
  • There was a pretty large merge conflict in ci.yml, so that will probably need to be looked at (though I think I remember CI failing after the last PR)

@veelci
Copy link
Contributor Author

veelci commented May 10, 2024

Closing due to #44

@veelci veelci closed this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants