Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligned model fix #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

kthakore
Copy link

@kthakore kthakore commented Dec 5, 2019

Adding the guard that ensures that the model file is aligned when compiled into program memory. Without this guard the tensorarena is misaligned and libraries that add uneven bytes to program memory could cause a seg fault when the TFInterpeter is invoked. @sandeepmistry and I found out about this during the ArmDevSummit 2019.

@sandeepmistry
Copy link
Contributor

Hi @kthakore,

Thanks to submitting this pull request!

There seems to be a lot more changes in this that I expected, maybe you need to apply this pull request to the following repo instead? https://github.com/arduino/AIoT-Dev-Summit-2019

@kthakore
Copy link
Author

kthakore commented Dec 5, 2019

Ah yep! I will update both separately ;)

…vent segfaults when TensorArena is used during TFInterperter invokation.
@kthakore
Copy link
Author

kthakore commented Dec 8, 2019

@sandeepmistry pushed up fix in both repo's ;)

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants