-
-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WiFi Ethernet fix MAC address reversed order #980
base: main
Are you sure you want to change the base?
Conversation
MACAddress(buff) is legacy Ethernet API, macAddress(buff) is WiFi API. so this solution preserves the error in PortnetaEthernet library and for Mbed Core WiFi library this PR changes the behavior of the macAddress function (and the 'tradition' of reversed MAC in WiFi libraries). so I guess there isn't a good solution for this. I would just remove the reversion completely. |
Thanks @JAndrassy i will doublecheck it, I was assuming it was reversed also in Ethernet library My goal was primarly to align the behaviour of |
we removed it recently for compatibility with esp32, esp8266, rp2040 ... |
yeah i've disagreed with myself one second after writing this 🙂 I will doublecheck the Ethernet MACAddress behaviour , It feels a bit strange to me that is not reversing the byte order since it is using the same socketWrapper function used in WiFi macAddress but maybe it get twisted one more time before. |
I meant Ethernet API in general. the Wiznet Ethernet library, the UIPEtherner etc |
ah ok, got it! |
rebased on latest main to fix ci.
|
MACAddress
is deprecated keeping the original reversed behaviour.uint8_t* macAddress(uint8_t * mac)
returns byte aligned withString macAddress()