Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Programmed External Keys. #33

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

TheShubham99
Copy link

This example shows how to use external buttons/keys as a keyboard using Keyboard Library

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arduino sketch filenames may not contain spaces.

The sketch filename must exactly match the folder name:

Keyboard
|_examples
   |_ProgrammableButtons
      |_ProgrammableButtons.ino

Please do a Tools > Auto Format if using the Arduino IDE or a Ctrl + B if using Arduino Web Editor to ensure the formatting of your code matches that of the other official Arduino example sketches.

Please always thoroughly test your code before submitting contributions.

Please set File > Preferences > Compiler Warnings to "All" and make sure your code doesn't generate any warnings.

examples/Programmable Buttons/Programmed External Keys.ino Outdated Show resolved Hide resolved
examples/Programmable Buttons/Programmed External Keys.ino Outdated Show resolved Hide resolved
examples/Programmable Buttons/Programmed External Keys.ino Outdated Show resolved Hide resolved
examples/Programmable Buttons/Programmed External Keys.ino Outdated Show resolved Hide resolved
examples/Programmable Buttons/Programmed External Keys.ino Outdated Show resolved Hide resolved
examples/Programmable Buttons/Programmed External Keys.ino Outdated Show resolved Hide resolved
examples/Programmable Buttons/Programmed External Keys.ino Outdated Show resolved Hide resolved
examples/Programmable Buttons/Programmed External Keys.ino Outdated Show resolved Hide resolved
examples/Programmable Buttons/Programmed External Keys.ino Outdated Show resolved Hide resolved
examples/Programmable Buttons/Programmed External Keys.ino Outdated Show resolved Hide resolved
Formating Done

Co-Authored-By: per1234 <[email protected]>
@TheShubham99
Copy link
Author

TheShubham99 commented Mar 18, 2020

I will take care of all the other suggestions too.

TheShubham99 and others added 11 commits March 18, 2020 19:01
Control structures simplified

Co-Authored-By: per1234 <[email protected]>
Example for native USB Arduino boards (e.g., Leonardo, Micro, MKR, Nano 33 IoT, Zero, Due)

- When the first button is pressed, the Ctrl + C keyboard shortcut (copy) is emulated.

-When the second button is pressed, the Ctrl + V keyboard shortcut (paste) is emulated.
Copy link
Author

@TheShubham99 TheShubham99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@per1234 I think I have done all the suggested changes.
Let me know if there are still any issues/suggestions, which need to be resolved.
Thank you for your time & suggestions :)

Copy link
Author

@TheShubham99 TheShubham99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@per1234
Thank you for guiding me through this :) 👍

Please check this #33 (comment) comment too.

I have done all the requested changes. Please review..

Copy link
Author

@TheShubham99 TheShubham99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@per1234
Done with all the requested changes. (including the button trigger)

examples/ProgrammableButtons/ProgrammableButtons.ino Outdated Show resolved Hide resolved
examples/ProgrammableButtons/ProgrammableButtons.ino Outdated Show resolved Hide resolved
Copy link
Author

@TheShubham99 TheShubham99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @per1234 👍 :)
I have implemented all of the required changes. :)

Please review it again :)

@per1234 per1234 dismissed their stale review March 21, 2020 13:45

Requested changes have been made. Thanks!

@TheShubham99
Copy link
Author

@per1234 Can we merge the Example?

@per1234
Copy link
Contributor

per1234 commented Mar 22, 2020

@TheShubham99 I'm not the person who decides which pull requests get merged. I only share my opinions in PR reviews in hopes it will be helpful.

Arduino's developers have a huge amount of software to maintain and are always working on very important and exciting projects. When you submit a pull request, you need to be willing to be patient. We should avoid making unproductive comments on the pull request threads, as the "noise" may cause the developers to be less productive in their important work, and thus result in longer delays before they can find the time to review non-essential pull requests.

@TheShubham99 TheShubham99 changed the title Created Programmed External Keys feat: Add Programmed External Keys. Jun 26, 2020
@per1234 per1234 removed their request for review March 10, 2021 00:01
@CLAassistant
Copy link

CLAassistant commented Apr 9, 2021

CLA assistant check
All committers have signed the CLA.

@per1234 per1234 added topic: documentation Related to documentation for the project type: enhancement Proposed improvement labels Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: documentation Related to documentation for the project type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants