Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency node-fetch to v3 #4418

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 23, 2022

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
node-fetch ^2.6.5 -> ^3.0.0 age adoption passing confidence

Release Notes

node-fetch/node-fetch

v3.2.4

Compare Source

Bug Fixes

v3.2.3

Compare Source

Bug Fixes

v3.2.2

Compare Source

Bug Fixes

v3.2.1

Compare Source

Bug Fixes

v3.2.0

Compare Source

Features

v3.1.1

Compare Source

Security patch release

Recommended to upgrade, to not leak sensitive cookie and authentication header information to 3th party host while a redirect occurred

What's Changed

New Contributors

Full Changelog: node-fetch/node-fetch@v3.1.0...v3.1.1

v3.1.0

Compare Source

What's Changed

New Contributors

Full Changelog: node-fetch/node-fetch@v3.0.0...v3.1.0

v3.0.0

Compare Source

version 3 is going out of a long beta period and switches to stable

One major change is that it's now a ESM only package
See changelog for more information about all the changes.


Configuration

📅 Schedule: "after 10pm,before 6:00am" in timezone Europe/Warsaw.

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Apr 23, 2022
@changeset-bot
Copy link

changeset-bot bot commented Apr 23, 2022

⚠️ No Changeset found

Latest commit: c7cdfb6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Apr 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
graphql-tools ⬜️ Ignored (Inspect) Apr 28, 2022 at 11:14AM (UTC)

@theguild-bot
Copy link
Collaborator

theguild-bot commented Apr 23, 2022

The latest changes of this PR are not available as alpha, since there are no linked changesets for this PR.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 23, 2022

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 272       ✗ 0  
     data_received..................: 32 MB   3.1 MB/s
     data_sent......................: 116 kB  12 kB/s
     http_req_blocked...............: avg=8.43µs   min=3.1µs    med=3.9µs    max=580.38µs p(90)=4.75µs   p(95)=5.05µs  
     http_req_connecting............: avg=3.59µs   min=0s       med=0s       max=488.69µs p(90)=0s       p(95)=0s      
   ✓ http_req_duration..............: avg=68.52ms  min=59.51ms  med=64.34ms  max=174.94ms p(90)=77.35ms  p(95)=99.9ms  
       { expected_response:true }...: avg=68.52ms  min=59.51ms  med=64.34ms  max=174.94ms p(90)=77.35ms  p(95)=99.9ms  
     http_req_failed................: 0.00%   ✓ 0         ✗ 136
     http_req_receiving.............: avg=145.5µs  min=122.39µs med=139.89µs max=280.29µs p(90)=157.89µs p(95)=170.64µs
     http_req_sending...............: avg=150.32µs min=19.7µs   med=26.65µs  max=3.76ms   p(90)=46.79µs  p(95)=934.88µs
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=68.22ms  min=59.33ms  med=64.17ms  max=174.59ms p(90)=76.52ms  p(95)=99.73ms 
     http_reqs......................: 136     13.519738/s
     iteration_duration.............: avg=73.94ms  min=64.06ms  med=69.51ms  max=180.28ms p(90)=86.3ms   p(95)=104.52ms
     iterations.....................: 136     13.519738/s
     vus............................: 1       min=1       max=1
     vus_max........................: 1       min=1       max=1

@Ginxo
Copy link

Ginxo commented Apr 27, 2022

any news about this? thanks a lot. Shouldn't be graphql-request dependency upgraded to 4.2.0 as well?

@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch from 4666e9a to c7cdfb6 Compare April 28, 2022 11:11
@ardatan
Copy link
Owner

ardatan commented May 1, 2022

Unfortunately we are not able to get this merged because Node-Fetch v3 is ESM only package while our packages support both ESM and CJS.

@ardatan ardatan closed this May 27, 2022
@ardatan ardatan deleted the renovate/node-fetch-3.x branch June 6, 2022 10:06
@renovate
Copy link
Contributor Author

renovate bot commented Aug 1, 2022

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 3.x releases. But if you manually upgrade to 3.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants