Rename DF functions to be consistent with Python DF functions.

[ruebot]

GitHub issue(s): #366

What does this Pull Request do?

Rename DF functions to be consistent with Python DF functions.

How should this be tested?

• TravisCI (unit tests) should take care of it.

Additional Notes:

1. @lintool the only part of the issue I haven't resolved here is your proposal to move WebArchive to RecordLoader.loadArchives on the Python side. I don't believe we can have RecordLoader.loadArchives as an actual class name. So, should we change things in the other direction or both directions? I've been naming a val warcs a lot in my example. What if we did something like that? Or webArchives or webarchives ? Once we settle on something, I'll the PR out of draft.

2. There will be a TONNE of documentation updates to do. If I could get a hand there, that'd be super helpful. @SamFritz @ianmilligan1 that of any interest?

[codecov]

Codecov Report

Merging #379 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #379   +/-   ##
=======================================
  Coverage   76.16%   76.16%           
=======================================
  Files          40       40           
  Lines        1418     1418           
  Branches      268      268           
=======================================
  Hits         1080     1080           
  Misses        221      221           
  Partials      117      117

[ianmilligan1]

👀

Looks like a great PR in progress, and agreed, the documentation will be heavy-ish lifting. I can help out if you give me discrete chunks of work (between parental leave, grant writing, admin, and some unfortunate university admin work coming up, my time is a bit limited, but many hands makes for light work).

[lintool]

@rubot I'm not wedded to perfect alignment between Scala DF and Pyspark DF at this point... perhaps we should just wait for #371?

I would rather do the refactoring incrementally... i.e., let's get this merged, start fixing docs, etc.

[ruebot]

@lintool cool 🤘 🤘

[ianmilligan1]

Great! @ruebot and I can maybe work together or the docs? When I have time I can start a branch or vice versa.

[ruebot]

Cool. I'll update archivesunleashed/aut-docs#21 with the new names, then we can go from there? Or, if you want to start on another file, go for it. Shouldn't be too much besides that hopefully.

[ianmilligan1]

Sure, sounds good on updating the PR and going fro, there! I might be able to tackle some of this tomorrow, kids schedule permitting.