Fix enabling multiple languages if the APP_NAME in the db was "Arches" #11660
#11687
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This check sniffs for whether this urls.py is the one being run as a project (not included by any further apps). For core arches, this would only be true if running core arches without a project. This was failing on a Django exception inside i18n_patterns(). This check is the same check that we're using in project-level settings.py
|
@jacobtylerwalls the tests seem pretty angry here. I'm guessing related? |
This reverts commit fbc966a.
|
I'll back-burner that fix for bringing the dev experience into alignment with prod. was Worth a shot but too hot for a patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description of Change
setup_db creates a tile for the system setting
APP_NAMEwith a value of "Arches". If the application was running under wsgi.py, then it's likely that the arches system settings object fetched tiles, thus merging the APP_NAME setting tile into the django settings, causing the check against the django settings in urls.py to unexpectedly evaluate True, breaking the ability of a project to enable multiple languages. This wasn't caught in development because the dev workflow doesn't run wsgi.py and thus update_from_db() never ran.Two fixes:
APP_NAMEin core urls.py. Instead use the same check that's working well in projects to determine "is this project the project being served"merge system settings into the django settings in more cases, not just under wsgi.py but also during development. This was discussed at a recent standup. Fix the docstring that implies that this is not wanted.EDIT: will defer this fix, caused issues withsetup_db.Testing instructions
Issues Solved
Closes #11660
Checklist
Ticket Background