Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vitest globals to tsconfig #11413

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Conversation

jacobtylerwalls
Copy link
Member

Without this change, notice failure in archesproject/arches-lingo#86 in the ts linter:

arches_lingo/src/arches_lingo/utils.spec.ts:12:1 - error TS2582: Cannot find name 'describe'. Do you need to install type definitions for a test runner? Try `npm i --save-dev @types/jest` or `npm i --save-dev @types/mocha`.

12 describe("Build scheme hierarchy", () => {
   ~~~~~~~~

arches_lingo/src/arches_lingo/utils.spec.ts:13:5 - error TS2582: Cannot find name 'it'. Do you need to install type definitions for a test runner? Try `npm i --save-dev @types/jest` or `npm i --save-dev @types/mocha`.

13     it("Should shape schemes into TreeNodes", () => {
       ~~

arches_lingo/src/arches_lingo/utils.spec.ts:21:9 - error TS2304: Cannot find name 'expect'.

21         expect(schemeNode.label).toEqual("Test Scheme");
           ~~~~~~

arches_lingo/src/arches_lingo/utils.spec.ts:22:9 - error TS2304: Cannot find name 'expect'.

22         expect(schemeNode.iconLabel).toEqual("Scheme");
           ~~~~~~

arches_lingo/src/arches_lingo/utils.spec.ts:23:9 - error TS2304: Cannot find name 'expect'.

23         expect(schemeNode.data.top_concepts.length).toEqual(1);
           ~~~~~~

arches_lingo/src/arches_lingo/utils.spec.ts:26:9 - error TS2304: Cannot find name 'expect'.

26         expect(topConcept.labels[0].value).toEqual("Concept 1");
           ~~~~~~

arches_lingo/src/arches_lingo/utils.spec.ts:27:9 - error TS2304: Cannot find name 'expect'.

27         expect(topConcept.narrower.length).toEqual(4);
           ~~~~~~

[1:38:04 PM] Found 9 errors. Watching for file changes.

Copy link
Contributor

@chrabyrd chrabyrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jacobtylerwalls jacobtylerwalls merged commit f687ba9 into dev/7.6.x Sep 3, 2024
7 checks passed
@jacobtylerwalls jacobtylerwalls deleted the jtw/vitest-globals branch September 3, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants