adds minimum width to scheme page items #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
changed the title
jacobtylerwalls
requested changes
Dec 13, 2024
There was a problem hiding this comment.
I still have the ability to make this almost as small as the original issue.
Should we bump from 25 to 33?
And can we use the prop for this instead of our own selector?
https://primevue.org/splitter/#api.splitterpanel.props.minSize
|
Great thought, I didn't check the hierarchy since it starts as turned off. The 25% of remaining real estate once the hierarchy is turned on is pretty small indeed. I bumped this to 33. I think it's still pretty ugly, but it's slightly better. The editor will improve, I think, with forthcoming requested changes where we strike the tabbed interface. |
jacobtylerwalls
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #145
Adds min-width at the splitter panel level - section level min-width is not respected at the section level. If desired, I can delve into that, but this seemed to solve the concern in #145 faster.