Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rough out scheme list #122
Rough out scheme list #122
Changes from 9 commits
4d369be
6fbd28c
383174c
0db42eb
3f770f2
e8f41be
9e71d84
f04058e
4b042a5
5a16a36
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an interesting pattern. An equally valid pattern would be to manually create a list item for this entry. However I like this just fine 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clicking this populates the front-end route with /placeholder-id, and then refreshing issues a request for that route which fails because placeholder-id is not a uuid. We should harden for this somehow, but maybe without necessarily creating dummy data on the backend that we have to filter out everywhere else (which is what I like about what you're doing here!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't exactly sure what to do, which is why I ended up punting with
placeholder-id
... My thought was that a PR for adding the scheme-editor and it's corresponding route would be coming hot on the heels of this, and we could just swapplaceholder-id
for the new scheme route.As you point out, it's probably not desirable to have a dummy uuid in lieu of string
placeholder-id
because we'd need to handle that on the back-end.Alternatively, I could mint the new scheme resourceid here - but I see that as less desirable since it would create a new uuid each time
/schemes
is visited, even if creating a new scheme is not the intention of the user.All that to say, I'm not exactly sure what to do about this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, got it. If we're about to swap in a new route for the scheme editor then all is good 👍