Skip to content

Commit

Permalink
update page names to conform to patterns, pr feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
aarongundel committed Dec 3, 2024
1 parent 3f500a7 commit 9605a1a
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 47 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ const { $gettext } = useGettext();
const props = defineProps<{
titleText: string;
}>();
const buttonText = $gettext(`Add ${props.titleText}`);
</script>

<template>
Expand All @@ -16,7 +14,7 @@ const buttonText = $gettext(`Add ${props.titleText}`);
<h2>{{ props.titleText }}</h2>
<div>
<Button
:label="buttonText"
:label="$gettext(`Add ${props.titleText}`)"
@click="$emit('openEditor')"
></Button>
</div>
Expand All @@ -34,7 +32,7 @@ const buttonText = $gettext(`Add ${props.titleText}`);
.section .header {
display: flex;
align-items: center;
border-bottom: 1px solid #ddd;
border-bottom: 1px solid var(--p-menubar-border-color);
}
.section .header h2 {
flex: 1;
Expand Down
28 changes: 18 additions & 10 deletions arches_lingo/src/arches_lingo/pages/SchemePage.vue
Original file line number Diff line number Diff line change
@@ -1,15 +1,23 @@
<script setup lang="ts">
import { inject } from "vue";
import { displayedRowKey } from "@/arches_lingo/constants.ts";
import type { DisplayedRowRefAndSetter } from "@/arches_lingo/types";
const { displayedRow } = inject(
displayedRowKey,
) as unknown as DisplayedRowRefAndSetter;
import Splitter from "primevue/splitter";
import SplitterPanel from "primevue/splitterpanel";
import SchemeLicense from "@/arches_lingo/components/scheme/report/SchemeLicense.vue";
import SchemeNote from "@/arches_lingo/components/scheme/report/SchemeNote.vue";
import SchemeUri from "@/arches_lingo/components/scheme/report/SchemeUri.vue";
import SchemeStandard from "@/arches_lingo/components/scheme/report/SchemeStandard.vue";
import SchemeAuthority from "@/arches_lingo/components/scheme/report/SchemeAuthority.vue";
</script>

<template>
<pre style="text-wrap: auto">{{ displayedRow }}</pre>
<div>
<Splitter>
<SplitterPanel>
<SchemeNote />
<SchemeAuthority />
<SchemeStandard />
<SchemeLicense />
<SchemeUri />
</SplitterPanel>
</Splitter>
</div>
</template>
23 changes: 0 additions & 23 deletions arches_lingo/src/arches_lingo/pages/SchemeReport.vue

This file was deleted.

10 changes: 0 additions & 10 deletions arches_lingo/src/arches_lingo/routes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,16 +59,6 @@ export const routes = [
requiresAuthentication: true,
},
},
{
path: "/scheme/:id/report",
name: "scheme",
component: () => import("@/arches_lingo/pages/SchemeReport.vue"),
meta: {
shouldShowNavigation: true,
shouldShowHierarchy: true,
requiresAuthentication: true,
},
},
];

export const routeNames = {
Expand Down

0 comments on commit 9605a1a

Please sign in to comment.