Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean-up redundant items: files and functions. #2410

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Clean-up redundant items: files and functions. #2410

merged 2 commits into from
Oct 16, 2024

Conversation

thorstenhater
Copy link
Contributor

Some justifications:

  • power & Co: only useful on Cray, likely outdated. Use external power measurements if this is relevant.
  • trace.hpp was never used and was locked_ostream's only user.

boeschf
boeschf approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@boeschf boeschf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks - 1243 lines gone!

@thorstenhater thorstenhater merged commit 7d1f82e into arbor-sim:master Oct 16, 2024
22 of 23 checks passed
@thorstenhater
Copy link
Contributor Author

and good riddance.

@thorstenhater thorstenhater deleted the qa/remove-trace branch October 16, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boeschf boeschf boeschf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thorstenhater @boeschf