C++20 Spaceship operator #2401
Merged
C++20 Spaceship operator #2401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boeschf
reviewed
Sep 12, 2024
arbor/util/counter.hpp
Outdated
|
|
||
| counter& operator=(const counter&) = default; | ||
| counter& operator=(counter&&) = default; | ||
|
|
||
| private: |
There was a problem hiding this comment.
why is it needed to make this public?
There was a problem hiding this comment.
Good question, likely a spurious delete.
Co-authored-by: boeschf <[email protected]>
|
cscs-ci run default |
boeschf
previously approved these changes
Sep 18, 2024
boeschf
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step along the road to C++20: Use the
<=>operator instead of homebaked macros.Also says goodbye to MacOS 12 and associated apple-clang, which is completely out of touch.