added brunel network tutorial #2387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thorstenhater
requested changes
Aug 19, 2024
doc/tutorial/brunel.rst
Outdated
| :lines: 62-81 | ||
|
|
||
|
|
||
| The Brunel network is randomly sparsely connected with a fixed in-degree regulated by a connection probability (:math:`\epsilon`). We, therefore, define a function to enable random connectivity. |
There was a problem hiding this comment.
A short explanation what sample_subset aims to achieve?
| sim.run(tfinal * U.ms, dt * U.ms) | ||
|
|
||
|
|
||
| print("This is simulating Brunel network in Arbor!") |
There was a problem hiding this comment.
Needed? Looks like debugging :D
Co-authored-by: Thorsten Hater <[email protected]>
… in all relevant files
thorstenhater
requested changes
Aug 21, 2024
There was a problem hiding this comment.
Almost there, a few comments:
- The images do not render in the preview build, something is off there. See https://arbor--2387.org.readthedocs.build/en/2387/tutorial/brunel.html#the-full-code
- Lint is failing due to the
####marks. I'd suggest removing those. - Lint also doesn't like
import *, but here it's ok. I'll find a way to disable it, if you like. Alternatively, you could use a really short name, e.g.import parameters as P.
thorstenhater
requested changes
Aug 21, 2024
fixed typo etc Co-authored-by: Thorsten Hater <[email protected]>
Co-authored-by: Thorsten Hater <[email protected]>
thorstenhater
requested changes
Aug 21, 2024
file.text
Outdated
There was a problem hiding this comment.
This one shouldn't be here, right?
.flake8
Outdated
| @@ -23,3 +23,7 @@ extend-exclude = | |||
| build, | |||
| # nah, don't care | |||
| spack/package.py | |||
| per-file-ignores= | |||
| python/example/brunel/analysis.py=F405,F403 | |||
There was a problem hiding this comment.
Suggested change
| python/example/brunel/analysis.py=F405,F403 | |
| python/example/brunel/analysis.py:F405,F403 |
and the next two lines.
python/example/brunel/parameters.py
Outdated
| import numpy as np | ||
|
|
||
|
|
||
| #### define network parameters #### |
There was a problem hiding this comment.
Suggested change
| #### define network parameters #### | |
| # define network parameters |
thorstenhater
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added Brunel network tutorial on Arbor
Closes: #1933