fixed the writing #2289
Merged
fixed the writing #2289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thorstenhater
requested changes
Jul 24, 2024
| @@ -45,17 +45,17 @@ This can be done by manually building a segment tree. The important bit here is | |||
| that ``append`` will take an id to attach to and return the newly added id. This | |||
| is exceptionally handy when building a tree structure, as we can elect to | |||
| remember or overwrite the last id. Alternatively, you could use numeric ids -- | |||
| they are just sequentially numbered by insertion order --, but we find that this | |||
| they are just sequentially numbered by insertion order -- but we find that this | |||
There was a problem hiding this comment.
Nitpick: These really should be ---, not --, which is the correct usage for parenthetical statements.
thorstenhater
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.