-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create less intermediate data from events #2249
Merged
thorstenhater
merged 36 commits into
arbor-sim:master
from
thorstenhater:perf/create-less-event-data
Sep 17, 2024
Merged
Create less intermediate data from events #2249
thorstenhater
merged 36 commits into
arbor-sim:master
from
thorstenhater:perf/create-less-event-data
Sep 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cscs-ci run daint-mc |
boeschf
reviewed
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, some code is duplicated between the backends, see this PR.
factorized streams
boeschf
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimizes event handling by removing the intermediate structure created by this chain
of transformations:
event_lanes := vector<vector<event>>
(one lane per local cell, each lane sorted by time)staged_events_per_mech_id := vector<vector<vector<deliverable_event>>>
(one vector per mech id and time step, sorted by time)vector<event_stream>
one stream per mech idThe following optimisations where performed:
cable_cell_group
deliverable_event
anddeliverable_event_data
event_stream
now uses a partition instead of a vector of ranges for splitting its data intodt
buckets. (Save 8B perdt
;))The result is that the quite pathological example
calcium_stdp.py
(as given in which generates immense amountsof spikes using a single cell group and a single epoch drops from 3.8GB heap to 1.9GB heap usage at peak
using the same runtime or slightly less (<5% difference).
TODO