Typestub #2238
Closed
Typestub #2238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
|
See the infamous #2233, added via the same generator and fixing all the 'mishaps', including massaging order, I'll happily take the automation of stubbing, though ;) autodoc has been discussed, but never used in anger, fell free to explore that idea! |
|
I already had the feeling this was going to be a dupe, but I couldn't stop myself ;) For automation, it seems like it mostly put If so, what I could do for now, in terms of automation, is to generate a new stub, and compare them via an ast visitor, that only overwrites non-ellipsis diffs? So if we've manually set an ellipsis to some more information that that change isn't reverted? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a
.pyifile (first 3 hours by hand, then stumbled uponpybind11-stubgen, and another hour of linting). But now I think we have a type stub?I think using this stub and
sphinx.ext.autodocwe could replace large chunks of the manually generated documentation. I also added a tiny check to confirm that everything that's in thearbormodule has a counterpart in the.pyito CI.