Apply suggestions from code review

Co-authored-by: boeschf <[email protected]>
arbor-sim · Oct 18, 2024 · 5364215 · 5364215
1 parent e4cb64e
commit 5364215
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/arbor/include/arbor/cv_policy.hpp b/arbor/include/arbor/cv_policy.hpp
@@ -74,7 +74,7 @@ struct ARB_SYMBOL_VISIBLE cv_policy {
     template <typename Impl, typename = std::enable_if_t<!std::is_same_v<std::remove_cvref_t<Impl>, cv_policy>>>
     explicit cv_policy(const Impl& impl): impl_(std::make_unique<wrap<Impl>>(impl)) {}
     template <typename Impl, typename = std::enable_if_t<!std::is_same_v<std::remove_cvref_t<Impl>, cv_policy>>>
-    explicit cv_policy(Impl&& impl): impl_(std::make_unique<wrap<Impl>>(impl)) {}
+    explicit cv_policy(Impl&& impl): impl_(std::make_unique<wrap<Impl>>(std::move(impl))) {}
     // move
     cv_policy(cv_policy&&) = default;
     cv_policy& operator=(cv_policy&&) = default;

diff --git a/arborio/cableio.cpp b/arborio/cableio.cpp
@@ -360,7 +360,7 @@ morphology make_morphology(const std::vector<std::variant<branch_tuple>>& args)
 }
 
 // Define cable-cell maker
-// Accepts the morphology, decor and label_dict arguments in any order as a vector
+// Accepts the morphology, decor, label_dict and cv_policy arguments in any order as a vector
 cable_cell make_cable_cell4(const std::vector<std::variant<morphology, label_dict, decor, cv_policy>>& args) {
     decor dec;
     label_dict dict;

diff --git a/doc/python/cable_cell.rst b/doc/python/cable_cell.rst
@@ -58,7 +58,7 @@ Cable cells
         :type decorations: :py:class:`decor`
         :param labels: dictionary of labeled regions and locsets
         :type labels: :py:class:`label_dict`
-        :param labels: discretization policy
+        :param discretization: discretization policy
         :type discretization: :py:class:`cv_policy`
 
     .. method:: discretization(policy)