-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create keybaseLabels.json #19
base: master
Are you sure you want to change the base?
Conversation
json file for labeling members within the DAO DApp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this as I think its useful. Though we should revisit how we keep it up to date as we revisit the membership onboarding processes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'm approving not block anything (sorry for the late response) but I have some concerns:
- Do we have to mantain 2 lists now (README and this json file)? Actually, they are already out of sync.
- How has this been generated? It would be good to provide a script along with this PR.
- What's the order in this file? It's different than in README file, so it makes it harder to spot differences.
For the moment, I'd say yes!! although we still need to pullish/optimize/simplify the membershing onboarding process.
it was generated through the new labeling funcionality of the last aragon version and exporting it from the AragonCoop DAO. what kind of script do you @bingen have in mind?
seems to be a random order actually (it was automatically generated from the DApp :-) |
I was thinking one that extracts json file from README, or the other way around, so we don't have to maintain both. |
This would definitely be nice. It may also be nice to rethink how people actually apply for membership, the current process does not seem very intuitive, most people have had some issue with the commit itself or the keybase verification method, and some are not familiar with how to create a PR. |
json file for labeling members within the DAO DApp