Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typos in contract and comments #594

Merged
merged 4 commits into from
May 15, 2024
Merged

fix: typos in contract and comments #594

merged 4 commits into from
May 15, 2024

Conversation

clauBv23
Copy link
Contributor

@clauBv23 clauBv23 commented May 14, 2024 •
edited
Loading

Description

This PR fixes some minor typos in the contracts.

Task ID: No task

Type of change

See the framework lifecycle in packages/contracts/docs/framework-lifecycle to decide what kind of change this pull request is.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.
  • I have updated the Subgraph and added a QA URL to the description of this PR.

heueristik
heueristik previously approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@heueristik heueristik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@clauBv23 clauBv23 merged commit f607746 into develop May 15, 2024
17 checks passed
@clauBv23 clauBv23 deleted the fix/typo branch May 15, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banasa44 banasa44 banasa44 approved these changes

@heueristik heueristik heueristik approved these changes

@Rekard0 Rekard0 Awaiting requested review from Rekard0

@jordaniza jordaniza Awaiting requested review from jordaniza

@novaknole novaknole Awaiting requested review from novaknole

Assignees
No one assigned
Labels
contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clauBv23 @heueristik @banasa44