F/OS-1224 Multisig approvers not appearing in past proposals #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since there is a branch for removing all plugins, multisig included, f/split-linting, not sure if this should be done only in this repo |
Yes, this should also be done in the split repo, but i wanted to first get the fix reviewed and then aply it also to the other repo |
jordaniza
reviewed
Apr 24, 2024
Co-authored-by: Jordan <[email protected]>
clauBv23
reviewed
Apr 24, 2024
|
@clauBv23 I fixed the lint missues that you mentioned, I also took the librety some others that popped up when I ran yarn lint. I also updated the description in the |
jordaniza
approved these changes
Apr 25, 2024
clauBv23
approved these changes
Apr 26, 2024
Rekard0
pushed a commit
that referenced
this pull request
May 17, 2024
* fix: multisig members not appearing in past proposals * wip * chore: update schema and methods * Update packages/subgraph/schema.graphql Co-authored-by: Jordan <[email protected]> * style: fix lint warnings * docs: improve graphql schema comments --------- Co-authored-by: Jordan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some approvers did not appear as approvers on past proposals after they've been removed from the multisig because the entity for the multisift members and approvers was related.
This fixes this issue using the solution discussed here: https://www.notion.so/aragonorg/Subgraph-Bug-Approvers-Query-Breaks-Multisig-Subgraph-d783e196ba464595974ba2a9d2dac80a#5ca1bd831bbd4dc191dd8fb0d4360e8f
Task ID: OS-1224
Playground: https://subgraph.satsuma-prod.com/aragon/osx-test-members-bug-mainnet/version/5/playground
Type of change
See the framework lifecycle in
packages/contracts/docs/framework-lifecycleto decide what kind of change this pull request is.Checklist:
CHANGELOG.mdfile in the root folder.DEPLOYMENT_CHECKLISTfile in the root folder.UPDATE_CHECKLISTfile in the root folder.