Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deploy(contracts): improves management DAO proposal readability #516

Merged
merged 3 commits into from
Jan 3, 2024
Merged

deploy(contracts): improves management DAO proposal readability #516

merged 3 commits into from
Jan 3, 2024

Conversation

mathewmeconry
Copy link
Contributor

@mathewmeconry mathewmeconry commented Dec 20, 2023 •
edited by jira bot
Loading

Description

Please include a summary of the change and be sure you follow the contributions rules we do provide here

Task ID: OS-898

Type of change

See the framework lifecylce in packages/contracts/docs/framework-lifecycle to decide what kind of change this pull request is.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.

heueristik
heueristik approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@heueristik heueristik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mathewmeconry mathewmeconry merged commit f48c1cb into develop Jan 3, 2024
23 checks passed
@mathewmeconry mathewmeconry deleted the OS-898-fix-deploy-script-managing-dao-update-proposal-should-not-try-to-execute branch January 3, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josemarinas josemarinas josemarinas approved these changes

@heueristik heueristik heueristik approved these changes

@Rekard0 Rekard0 Awaiting requested review from Rekard0

Assignees
No one assigned
Labels
contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mathewmeconry @heueristik @josemarinas