Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: maintained changelog #478

Merged
merged 2 commits into from
Oct 10, 2023
Merged

chore: maintained changelog #478

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23ca1db
chore: maintained changelog
heueristik Oct 5, 2023
28fd288
chore: maintained changelog
heueristik Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions packages/contracts/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## v1.4.0-rc0
## v1.4.0
heueristik marked this conversation as resolved.
Show resolved Hide resolved

### Added

Expand All @@ -26,21 +26,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Removed unused `ERC1271Mock` contract.
- Removed the `setSignatureValidator` function and `signatureValidator` variable in `DAO`. In places, where the function must remain to not alter the `IDAO` interface ID, it will revert and explanatory notes are put in place..

## v1.3.1-rc0

### Added
## v1.3.1
heueristik marked this conversation as resolved.
Show resolved Hide resolved

### Changed

- Added missing `virtual` keyword to `PermissionCondition` and `PermissionConditionUpgradeable`.

### Removed
- Added `PermissionCondition` and `PermissionConditionUpgradeable` to have ERC-165 support for `IPermissionCondition` implementations.

## v1.3.0-rc0
## v1.3.0

### Added

- Added `PermissionCondition` and `PermissionConditionUpgradeable` to have ERC-165 support for `IPermissionCondition` implementations.
- Inherit `ProtocolVersion` and `ERC165` in `DAOFactory` and `PluginRepoFactory`.
- Inherit `ProtocolVersion` in `DAO` and `PluginRepo`.
- Added a `nonReentrant` modifier to the `execute` function in the `DAO` contract.
Expand All @@ -49,6 +44,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- Added missing `virtual` keyword to `PermissionCondition` and `PermissionConditionUpgradeable`.
- Changed `TokenVotingSetup` to receive the `GovernanceERC20` and `GovernanceWrappedERC20` base contracts as constructor arguments to reduce the `initCode` size because of limitations on the Goerli testnet.
- Revert with errors (`ConditionNotAContract`, `ConditionInterfacNotSupported`) if the `grantWithCondition` function in `PermissionManager` is called with a condition address that is not a `IPermissionCondition` implementation.
- `_grantWithCondition()` doesn't accept `ALLOW_FLAG` anymore as valid condition input.
Expand Down
Loading