Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add interface tests and subgraph renaming #474

Merged
merged 2 commits into from
Oct 5, 2023
Merged

test: add interface tests and subgraph renaming #474

merged 2 commits into from
Oct 5, 2023

Conversation

heueristik
Copy link
Contributor

@heueristik heueristik commented Sep 28, 2023 •
edited by jira bot
Loading

Description

Task: OS-694

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.

@heueristik heueristik marked this pull request as ready for review September 28, 2023 12:20
@heueristik heueristik requested review from mathewmeconry, Rekard0 and josemarinas and removed request for mathewmeconry September 28, 2023 12:22
@heueristik heueristik force-pushed the feature/OS-694-interface-checks branch from 205bde1 to b662dde Compare September 28, 2023 12:28
mathewmeconry
mathewmeconry previously approved these changes Sep 29, 2023
View reviewed changes
@heueristik heueristik merged commit aab6b9b into develop Oct 5, 2023
11 checks passed
@heueristik heueristik deleted the feature/OS-694-interface-checks branch October 5, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rekard0 Rekard0 Rekard0 approved these changes

@mathewmeconry mathewmeconry mathewmeconry approved these changes

@josemarinas josemarinas Awaiting requested review from josemarinas

Assignees
No one assigned
Labels
contracts subgraph
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heueristik @mathewmeconry @Rekard0