Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Framework lifecycle (non-breaking changes) #471

Merged
merged 20 commits into from
Oct 23, 2023
Merged

docs: Framework lifecycle (non-breaking changes) #471

merged 20 commits into from
Oct 23, 2023

Conversation

heueristik
Copy link
Contributor

@heueristik heueristik commented Sep 22, 2023 •
edited
Loading

Description

Task: OS-652

Type of change

  • docs

Checklist:

  • I have selected the correct base branch.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.

@heueristik heueristik marked this pull request as ready for review September 26, 2023 12:25
Rekard0
Rekard0 previously approved these changes Oct 6, 2023
View reviewed changes
@pythonpete32 pythonpete32 self-requested a review October 19, 2023 06:50
pythonpete32
pythonpete32 previously approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@pythonpete32 pythonpete32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a bunch of edits for the URLs, other than those looks great. It was very helpful to read through all those docs!

@heueristik @pythonpete32
docs: fix links
fd03945 
Co-authored-by: Aaron Abu Usama <[email protected]>
@heueristik heueristik requested review from Rekard0 and pythonpete32 and removed request for mathewmeconry October 23, 2023 08:00
@pythonpete32 pythonpete32 merged commit e7ba460 into develop Oct 23, 2023
12 checks passed
@heueristik heueristik deleted the feature/framework-lifecycle branch October 24, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pythonpete32 pythonpete32 pythonpete32 approved these changes

@Rekard0 Rekard0 Rekard0 approved these changes

Assignees
No one assigned
Labels
contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heueristik @Rekard0 @pythonpete32