Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: revoke SET_SIGNATURE_VALIDATOR_PERMISSION that was granted to previous DAO versions #468

Merged
merged 1 commit into from
Sep 21, 2023
Merged

fix: revoke SET_SIGNATURE_VALIDATOR_PERMISSION that was granted to previous DAO versions #468

merged 1 commit into from
Sep 21, 2023

Conversation

heueristik
Copy link
Contributor

@heueristik heueristik commented Sep 21, 2023 •
edited by jira bot
Loading

Description

Task: OS-718

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.

@heueristik heueristik changed the title fix: revoke SET_SIGNATURE_VALIDATOR_PERMISSION granted to previous DA… fix: revoke SET_SIGNATURE_VALIDATOR_PERMISSION that was granted to previous DAO versions Sep 21, 2023
@heueristik heueristik marked this pull request as ready for review September 21, 2023 12:25
@heueristik heueristik merged commit 2a10844 into develop Sep 21, 2023
27 checks passed
@heueristik heueristik deleted the hotfix/OS-718-revoke-set-signature-validator-permission branch September 21, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rekard0 Rekard0 Rekard0 approved these changes

@mathewmeconry mathewmeconry mathewmeconry approved these changes

Assignees
No one assigned
Labels
contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heueristik @mathewmeconry @Rekard0