fix: improved naming of verifyContracts and verifyProxies tag

aragon · Mar 4, 2024 · 3b31b4f · 3b31b4f
1 parent 6f06328
commit 3b31b4f
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/DEPLOYMENT_CHECKLIST.md b/DEPLOYMENT_CHECKLIST.md
@@ -55,7 +55,7 @@ To deploy run `yarn deploy --network NETWORK` in `packages/contracts` and replac
 - [ ] Go to the blockchain explorer and verify that each address is verified
   - [ ] If it is not try to verfiy it with `npx hardhat verify --network NETWORK ADDRESS CONTRUCTOR-ARGS`. More infos on how to use this command can be found here: [https://hardhat.org/hardhat-runner/docs/guides/verifying](https://hardhat.org/hardhat-runner/docs/guides/verifying)
   - [ ] If it is a proxy try to activate the blockchain explorer's proxy feature
-    - [ ] Try running `yarn verifyProxies --network <network>` to automate this
+    - [ ] Try running `yarn linkProxies --network <network>` to automate this
   - [ ] If the proxies are not verified with the `Similar Match Source Code` feature
     - [ ] Verify one of the proxies
     - [ ] Check if the other proxies are now verified with `Similar Match Source Code`

diff --git a/UPDATE_CHECKLIST.md b/UPDATE_CHECKLIST.md
@@ -65,7 +65,7 @@ If the deployer **is** allowed to create a proposal
 - [ ] Go to the blockchain explorer and verify that each address is verified
   - [ ] If it is not try to verfiy it with `npx hardhat verify --network NETWORK ADDRESS CONTRUCTOR-ARGS`. More infos on how to use this command can be found here: [https://hardhat.org/hardhat-runner/docs/guides/verifying](https://hardhat.org/hardhat-runner/docs/guides/verifying)
   - [ ] If it is a proxy try to activate the blockchain explorer's proxy feature
-    - [ ] Try running `yarn verifyProxies --network <network>` to automate this
+    - [ ] Try running `yarn linkProxies --network <network>` to automate this
   - [ ] If the proxies are not verified with the `Similar Match Source Code` feature
     - [ ] Remove `import '@openzeppelin/hardhat-upgrades'` from `packages/contracts/hardhat.config.ts`
     - [ ] Verify one of the proxies

diff --git a/packages/contracts/deploy/verification/99_conclude/10_verify-contracts.ts b/packages/contracts/deploy/verification/99_conclude/10_verify-contracts.ts
@@ -27,7 +27,7 @@ const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
   }
 };
 export default func;
-func.tags = ['New', 'Verify', 'VerifyContracts'];
+func.tags = ['New', 'Verify', 'BlockExplorerUploadContracts'];
 func.runAtTheEnd = true;
 func.skip = (hre: HardhatRuntimeEnvironment) =>
   Promise.resolve(isLocal(hre.network));
diff --git a/...fication/99_conclude/11_verify-proxies.ts → ...rification/99_conclude/11_link-proxies.ts b/...fication/99_conclude/11_verify-proxies.ts → ...rification/99_conclude/11_link-proxies.ts
@@ -9,7 +9,7 @@ import {HardhatRuntimeEnvironment} from 'hardhat/types';
 
 /**
  * This script can be run manually after the deployment of the contracts and contract verification,
- * call `yarn verifyProxies --network <network>` to run this script.
+ * call `yarn linkProxies --network <network>` to run this script.
  *
  * It searches deployments for proxies and their implementations and links them on Etherscan.
  * This avoids the need to call 'Is this a proxy?' for each contract using the UI.
@@ -36,11 +36,11 @@ const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
 };
 export default func;
 
-func.tags = ['New', 'Verify', 'VerifyProxies'];
+func.tags = ['New', 'Verify', 'LinkProxies'];
 func.dependencies = ['VerifyContracts'];
 func.runAtTheEnd = true;
 
 func.skip = (hre: HardhatRuntimeEnvironment) => {
-  const verifyProxies = process.env.VERIFY_PROXIES === 'true';
+  const verifyProxies = process.env.LINK_PROXIES === 'true';
   return Promise.resolve(isLocal(hre.network) || !verifyProxies);
 };
diff --git a/packages/contracts/package.json b/packages/contracts/package.json
@@ -24,7 +24,7 @@
     "flatten": "hardhat flatten",
     "analyze": "mythx analyze",
     "deploy": "hardhat deploy",
-    "verifyProxies": "VERIFY_PROXIES=true yarn deploy --tags VerifyProxies",
+    "linkProxies": "LINK_PROXIES=true yarn deploy --tags LinkProxies",
     "deploy:local": "yarn deploy --network localhost --reset",
     "dev": "yarn hardhat node --hostname 0.0.0.0",
     "prepublishOnly": "yarn build && yarn build:npm",