ci: Regenerate Rust code when we update dependencies #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow missing docs for Rust code generated from Protobuf definitions. The `deny(missing_docs)` rule applies to the whole codebase, but this code is ultimately not under our control, so we have to make an exception.
Updating project dependencies during our tests may lead to an update in
the `protobuf` crate. It seems that such an update does not work well
with already generated Rust code from Protobuf definitions, and our CI
fails with errors like this:
error[E0425]: cannot find value `VERSION_3_6_0` in crate `protobuf`
--> src/../proto/metadata.rs:25:49
|
25 | const _PROTOBUF_VERSION_CHECK: () = ::protobuf::VERSION_3_6_0;
| ^^^^^^^^^^^^^ help: a constant with a similar name exists: `VERSION_3_7_1`
|
::: /home/apyrgio/playground/tindercrypt/target/debug/build/protobuf-81b136a5c49b834c/out/version.rs:7:1
|
7 | pub const VERSION_3_7_1: () = ();
| --------------------------- similarly named constant `VERSION_3_7_1` defined here
See this failed run for instance:
https://github.com/apyrgio/tindercrypt/actions/runs/11622120587/job/32367072109#step:5:157
It's probably best to re-generate this Rust code in our CI, just to be
on the safe side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating project dependencies during our tests may lead to an update in the
protobufcrate. It seems that such an update does not work well with already generated Rust code from Protobuf definitions, and our CI fails with errors like this:See this failed run for instance: https://github.com/apyrgio/tindercrypt/actions/runs/11622120587/job/32367072109#step:5:157
It's probably best to re-generate this Rust code in our CI, just to be on the safe side.