Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sanitization to properly accept vanity addresses #954

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

GhostWalker562
Copy link
Contributor

Description

When calling toStringLong, make sure the address accepted also accepts vanity addresses so that it can sanitize them.

Related Links

Tests
http://localhost:3000/account/0x4b9da755bccc9fa1d7aafc238118a420684db60cf8b2be0c93f6e4243660efe6?network=mainnet
http://localhost:3000/account/0x000000007c9f6724cfc3ead36713389148bbeb48a310dacd43a767b52ada4be7?network=mainnet

Checklist

Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for aptos-explorer ready!

Name Link
🔨 Latest commit 5109df2
🔍 Latest deploy log https://app.netlify.com/sites/aptos-explorer/deploys/6751fef997eba90008c7ad16
😎 Deploy Preview https://deploy-preview-954--aptos-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@GhostWalker562 GhostWalker562 merged commit 207bed0 into main Dec 5, 2024
7 checks passed
@GhostWalker562 GhostWalker562 deleted the fix-vanity-addresses branch December 5, 2024 19:32
@GhostWalker562 GhostWalker562 removed their assignment Dec 5, 2024
Copy link

sentry-io bot commented Dec 5, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: Hex string is too short, must be 1 to 64 chars long, excluding the leading 0x. /account/0x9d0595765a31f8d56e1d2aafc4d6c76f283c... View Issue
  • ‼️ TypeError: Cannot read properties of undefined (reading 'toStringLong') /validator/0x9bfd93ebaa1efd65515642942a607eeca5... View Issue
  • ‼️ Error: Hex characters are invalid: hex string expected, got non-hex character "0w" at index 34 /validator/wl_node_aptos_p2p-validator_1 View Issue
  • ‼️ Error: Hex string is too short, must be 1 to 64 chars long, excluding the leading 0x. /account/0x62d633ee81c71238afb4eea785afdd6e43f1... View Issue
  • ‼️ Error: Hex string is too short, must be 1 to 64 chars long, excluding the leading 0x. /account/0x9d0595765a31f8d56e1d2aafc4d6c76f283c... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants