-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add permissions for fungible assets operation #14567
base: 09-04-implement_rust_logics_for_permissioned_signer
Are you sure you want to change the base?
add permissions for fungible assets operation #14567
Conversation
⏱️ 2h 15m total CI duration on this PR
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 09-04-implement_rust_logics_for_permissioned_signer #14567 +/- ##
====================================================================================
Coverage 60.1% 60.1%
====================================================================================
Files 857 857
Lines 210762 210762
====================================================================================
+ Hits 126723 126744 +21
+ Misses 84039 84018 -21 ☔ View full report in Codecov by Sentry. |
dec4a79
to
6cd5fd0
Compare
350db4c
to
dad258f
Compare
6cd5fd0
to
88ad9a1
Compare
dad258f
to
6b4da66
Compare
88ad9a1
to
5f90e3a
Compare
6b4da66
to
b1fd015
Compare
5f90e3a
to
ef7be0f
Compare
b1fd015
to
6592c01
Compare
ef7be0f
to
cd6090b
Compare
6592c01
to
54c34ad
Compare
cd6090b
to
0df1c5a
Compare
54c34ad
to
1835d3d
Compare
0df1c5a
to
1bd468b
Compare
1835d3d
to
42decc7
Compare
1bd468b
to
40796a4
Compare
42decc7
to
6ac9449
Compare
40796a4
to
4940d7d
Compare
6ac9449
to
3ae6a87
Compare
4940d7d
to
d8742c4
Compare
3ae6a87
to
7fbfa3e
Compare
d8742c4
to
5d53f18
Compare
7fbfa3e
to
f3015ce
Compare
82bfd27
to
0fe7011
Compare
c6019db
to
d839540
Compare
0fe7011
to
38ebc59
Compare
d839540
to
a619fbe
Compare
38ebc59
to
2130d0f
Compare
coin::deposit(signer::address_of(alice), coin::mint(10000, &mint_cap)); | ||
|
||
let perm_handle = permissioned_signer::create_permissioned_handle(alice); | ||
let alice_perm_signer = permissioned_signer::signer_from_permissioned(&perm_handle); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function name is incorrect - should be signer_from_permissioned_handle instead of signer_from_permissioned to match the implementation in permissioned_signer module
Spotted by Graphite Reviewer (based on CI logs)
Is this helpful? React 👍 or 👎 to let us know.
a619fbe
to
61087d6
Compare
2130d0f
to
251e54b
Compare
61087d6
to
9e00f62
Compare
251e54b
to
e4b36b5
Compare
9e00f62
to
6f66b11
Compare
e4b36b5
to
ceb03c5
Compare
6f66b11
to
2d01317
Compare
ceb03c5
to
c839498
Compare
2d01317
to
ae5590b
Compare
0bf4bde
to
0e84b98
Compare
ae5590b
to
11615c1
Compare
0e84b98
to
c18d8ec
Compare
11615c1
to
571b09a
Compare
c18d8ec
to
47df813
Compare
571b09a
to
5798a2a
Compare
47df813
to
ed890c6
Compare
5798a2a
to
198df7d
Compare
ed890c6
to
0c03c3b
Compare
198df7d
to
2a56afe
Compare
0c03c3b
to
c1bc146
Compare
2a56afe
to
bde993b
Compare
c1bc146
to
790baf2
Compare
Description
Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
Key Areas to Review
Checklist